[mir-coders] anybody get that patch to do anything?

[Dan]

Mark,

I think the intention is to keep the original in another directory, wheras renameTo would move the file... 


Dan Garland
------------------------
numerouno at dangarland.co.uk
mob: +44 (0) 7979 770053
icq: 120963437
aim: dmgarland1767


-----Original Message-----
From: Mark Meyer <4meyer at informatik.uni-hamburg.de>
Date: Wed, 26 Apr 2006 18:50:27 
To:mir-coders at lists.indymedia.org
Subject: Re: [mir-coders] anybody get that patch to do anything?

On Wed, Apr 26, 2006 at 10:56:03AM +0100, yossarian wrote:
> Just wondering if anybody ever got that image-resize patch to do anything?

In your patch StreamCopier>>copyFile(File, File) (l. 509) you open two
streams on Files, then doing

  StreamCopier.copy(inputStream, outputStream)

you really want to File>>renameTo(File) cf. `java.io'.

Please note that dumping arbitrary data supplied over an untrusted
network gives everybody a chance to really hose your filesystems
performance.

There's a speling error on l. 38.

On line 29

  -import java.io.OutputStream;
  +import java.io.*;

wildcard imports make it really hard to cleanly track dependencies.
_______________________________________________
mir-coders mailing list
mir-coders at lists.indymedia.org
http://lists.indymedia.org/mailman/listinfo/mir-coders